Aggarwal-Raghav commented on PR #63:
URL: https://github.com/apache/hive-site/pull/63#issuecomment-3319759619

   > LGTM, will merge soon!
   > 
   > Below a small general advice (that I forgot to mention in the previous PR 
about HIVE-29102) and is relevant for future contributions to hive-site repo.
   > 
   > In general, is it best to avoid harcoding absolute URLs to 
`https://hive.apache.org` whenever possible. These URLs cannot be verified by 
Hugo and can easily go stale/break without anyone noticing. Using the `< ref >` 
directives can avoid this problem so it should be the prefferred way of adding 
links.
   > 
   > Absolute URLs, also make testing more difficult since when you preview the 
site locally some clicks will use the local version and some others will take 
you to the actual deployed version online.
   
   ACK


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to