deniskuzZ commented on code in PR #6086: URL: https://github.com/apache/hive/pull/6086#discussion_r2375791395
########## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java: ########## @@ -1873,8 +1873,55 @@ public enum ConfVars { " positive value will be used as-is." ), CATALOG_SERVLET_AUTH("metastore.catalog.servlet.auth", - "hive.metastore.catalog.servlet.auth", "jwt", new StringSetValidator("none", "simple", "jwt"), - "HMS Catalog servlet authentication method (none, simple, or jwt)." + "hive.metastore.catalog.servlet.auth", "jwt", new StringSetValidator("none", "simple", "jwt", "oauth2"), + "HMS Catalog servlet authentication method (none, simple, jwt, or oauth2)." + ), + CATALOG_SERVLET_AUTH_OAUTH2_ISSUER("metastore.catalog.servlet.auth.oauth2.issuer", Review Comment: i think `auth` in config name is redundant here. how about `metastore.catalog.servlet.oauth2.issuer`? btw is this a `oauth2-server-uri` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org