wecharyu commented on code in PR #6006:
URL: https://github.com/apache/hive/pull/6006#discussion_r2384243981
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java:
##########
@@ -114,12 +92,30 @@ public static boolean moveToTrash(FileSystem fs, Path f,
Configuration conf, boo
.contains("Snapshot"))
deleteReplRelatedSnapshots(fs, f);
// retry delete after attempting to delete replication related snapshots
- result = fs.delete(f, true);
+ fs.delete(f, true);
}
- if (!result) {
- LOG.error("Failed to delete " + f);
+ return true;
+ }
+
+ /**
+ * Move a particular file or directory to the trash.
+ * @param fs FileSystem to use
+ * @param f path of file or directory to move to trash.
+ * @param conf configuration object
+ * @return true if move successful
+ */
+ public static boolean moveToTrash(FileSystem fs, Path f, Configuration conf)
{
+ LOG.debug("moving " + f + " to trash");
Review Comment:
Addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
