difin commented on code in PR #6108:
URL: https://github.com/apache/hive/pull/6108#discussion_r2398791619


##########
itests/qtest-iceberg/pom.xml:
##########
@@ -475,6 +475,23 @@
       <version>${project.version}</version>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>org.apache.httpcomponents.client5</groupId>
+      <artifactId>httpclient5</artifactId>
+    </dependency>
+    <dependency>
+      <groupId>org.apache.httpcomponents.core5</groupId>
+      <artifactId>httpcore5</artifactId>
+    </dependency>
+    <dependency>
+      <groupId>org.apache.httpcomponents.core5</groupId>
+      <artifactId>httpcore5-h2</artifactId>
+    </dependency>
+    <dependency>
+      <groupId>org.testcontainers</groupId>
+      <artifactId>testcontainers</artifactId>
+      <scope>test</scope>
+    </dependency>

Review Comment:
   This is the utility that allows to execute docker container in tests - 
`GenericContainer` is from `testcontainers`:
   
   ```
     private void startGravitinoContainer() {
       gravitinoContainer = new GenericContainer<>(GRAVITINO_IMAGE)
           .withExposedPorts(9001)
           // Update entrypoint to create the warehouse directory before 
starting the server
           .withCreateContainerCmdModifier(cmd -> cmd.withEntrypoint("bash", 
"-c",
               String.format("mkdir -p %s && exec %s", warehouseDir.toString(), 
GRAVITINO_STARTUP_SCRIPT)))
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to