wecharyu commented on code in PR #6078:
URL: https://github.com/apache/hive/pull/6078#discussion_r2376312385


##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizableEvent.java:
##########
@@ -40,6 +44,30 @@ protected HiveMetaStoreAuthorizableEvent(PreEventContext 
preEventContext) {
     this.preEventContext = preEventContext;
   }
 
+  protected HiveAuthzContext buildAuthzContext(String commandString) {
+    HiveAuthzContext.Builder builder = new HiveAuthzContext.Builder();
+
+    if (commandString != null) {
+      builder.setCommandString(commandString);
+    }
+
+    builder.setForwardedAddresses(new ArrayList<>());

Review Comment:
   nit: also add the comment
   ```suggestion
       // TODO: refer to SessionManager/HiveSessionImpl for details on getting 
ipAddress and forwardedAddresses
       builder.setForwardedAddresses(new ArrayList<>());
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to