deniskuzZ commented on code in PR #6130:
URL: https://github.com/apache/hive/pull/6130#discussion_r2437323195
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##########
@@ -228,4 +228,9 @@ public void dropDatabase(DropDatabaseRequest req) {
validateCurrentCatalog(req.getCatalogName());
restCatalog.dropNamespace(Namespace.of(req.getName()));
}
+
+ @Override
+ public List<Table> getAllMaterializedViewObjectsForRewriting() {
+ return Collections.emptyList();
Review Comment:
ok, but for consistency, i think in the default method we should return an
empty list there as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
