Aggarwal-Raghav commented on PR #6129: URL: https://github.com/apache/hive/pull/6129#issuecomment-3416566731
> Should we update `alter_rename_table.q` and `repl_4_exim_nocolstat.q`, too? > > ``` > % git grep 'metastore.try.direct.sql' | grep '\.q:' | grep -v 'metaconf:' > ql/src/test/queries/clientpositive/alter_rename_table.q:set metastore.try.direct.sql=false; > ql/src/test/queries/clientpositive/alter_table_column_stats.q:-- Test for external tables with metastore.try.direct.sql.ddl as false > ql/src/test/queries/clientpositive/repl_4_exim_nocolstat.q:set metastore.try.direct.sql=false; > ql/src/test/queries/clientpositive/set_metaconf.q:set hive.metastore.try.direct.sql; > ql/src/test/queries/clientpositive/set_metaconf.q:set hive.metastore.try.direct.sql; > ``` yes. thanks for pointing it out. Not changing `set_metaconf.q` as it seems to be testing whether metaconf is changing HiveConf or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
