zabetak commented on code in PR #67:
URL: https://github.com/apache/hive-site/pull/67#discussion_r2425529008


##########
content/docs/latest/admin/hive-schema-tool.md:
##########
@@ -89,6 +89,8 @@ Version
 
 The dbType "`mssql`" was added in Hive 0.13.1 with 
[HIVE-6862](https://issues.apache.org/jira/browse/HIVE-6862).
 
+As of [HIVE-29246](https://issues.apache.org/jira/browse/HIVE-29246), the 
Derby driver class name has been updated to 
`org.apache.derby.iapi.jdbc.AutoloadedDriver`. If you are using Derby, please 
ensure you use this new class name.
+

Review Comment:
   Instead of adding this comment here, it probably makes more sense to update 
schematool output directly replacing driver with the new value. Anyways the 
usage examples should reflect what is the tool doing/printing now.
   
   In fact the output from these usage examples turns obsolete after every Hive 
release so we should either remove it completely or make sure that it gets 
updated regularly. History shows that we are probably gonna fail to maintain it 
up to date (unless there is automation in place) so I guess we should rather 
remove the output and just keep the command. (This removal is somewhat outside 
of the scope of this PR so we can defer it).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to