Aggarwal-Raghav commented on code in PR #6113:
URL: https://github.com/apache/hive/pull/6113#discussion_r2407892746
##########
ql/src/test/results/clientpositive/llap/jdbc_split_filter.q.out:
##########
@@ -146,9 +146,10 @@ HiveJdbcConverter(convention=[JDBC.DERBY])
JdbcAggregate(group=[{0, 4, 5}], agg#0=[sum($1)])
JdbcFilter(condition=[IS NULL($2)])
JdbcJoin(condition=[AND(=($1, $3), =($0, $2))], joinType=[left])
- JdbcProject(fkey=[$2], ikey=[$0])
+ HiveProject(fkey=[$2], ikey=[$0])
JdbcHiveTableScan(table=[[default, ext_simple_derby_table1]],
table:alias=[ext_simple_derby_table1])
- JdbcProject(fkey=[$2], ikey=[$0], datekey=[$4], dkey=[$3])
- JdbcFilter(condition=[AND(IS NOT NULL($0), IS NOT NULL($2))])
- JdbcHiveTableScan(table=[[default, ext_simple_derby_table2]],
table:alias=[ext_simple_derby_table2])
+ JdbcProject(fkey=[$1], ikey=[$0], datekey=[$3], dkey=[$2])
+ JdbcFilter(condition=[AND(IS NOT NULL($0), IS NOT NULL($1))])
Review Comment:
Are the additional modifications in these re-enabled tests, which are
unrelated to the JDBC URL changes, a result of commits merged after the tests
were originally disabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
