okumin commented on code in PR #6006:
URL: https://github.com/apache/hive/pull/6006#discussion_r2409663765


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -1139,7 +1139,7 @@ private void dropCatalogCore(String catName, boolean 
ifExists)
       }
     } finally {
       if (success) {
-        wh.deleteDir(wh.getDnsPath(new Path(cat.getLocationUri())), false, 
false, false);
+        wh.deleteDir(wh.getDnsPath(new Path(cat.getLocationUri())), false, 
false);

Review Comment:
   Just a note for myself and reviewers: As mentioned in the description, 
`HiveMetaStoreFsImpl#deleteDir` ignores the `recursive` argument, and that's 
why we can accept this change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to