kokila-19 commented on code in PR #6095: URL: https://github.com/apache/hive/pull/6095#discussion_r2389792357
########## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/udf/GenericUDFIcebergZorder.java: ########## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.mr.hive.udf; + +import java.nio.ByteBuffer; +import java.nio.charset.StandardCharsets; +import org.apache.hadoop.hive.ql.exec.Description; +import org.apache.hadoop.hive.ql.exec.UDFArgumentException; +import org.apache.hadoop.hive.ql.exec.UDFArgumentTypeException; +import org.apache.hadoop.hive.ql.metadata.HiveException; +import org.apache.hadoop.hive.ql.udf.generic.GenericUDF; +import org.apache.hadoop.hive.serde2.objectinspector.ObjectInspector; +import org.apache.hadoop.hive.serde2.objectinspector.PrimitiveObjectInspector; +import org.apache.hadoop.hive.serde2.objectinspector.primitive.PrimitiveObjectInspectorFactory; +import org.apache.hadoop.io.BytesWritable; +import org.apache.iceberg.util.ZOrderByteUtils; + +/** + * Hive UDF to compute the Z-order value of given input columns using Iceberg's ZOrderByteUtils. + * Supports various primitive types and converts inputs into interleaved binary representation. + */ +@Description(name = "iceberg_zorder", + value = "_FUNC_(value) - " + + "Returns the z-value calculated by Iceberg ZOrderByteUtils class") +public class GenericUDFIcebergZorder extends GenericUDF { + private PrimitiveObjectInspector[] argOIs; + // For variable-length types (e.g., strings), how many bytes contribute to z-order + private final int varLengthContribution = 8; + private transient ByteBuffer[] reUseBuffer; + private static final int MAX_OUTPUT_SIZE = Integer.MAX_VALUE; + + /** + * Initializes the UDF, validating argument types are primitives and preparing buffers. + */ + @Override + public ObjectInspector initialize(ObjectInspector[] arguments) throws UDFArgumentException { + if (arguments.length < 2) { + throw new UDFArgumentException("iceberg_zorder requires at least 2 arguments"); Review Comment: Z-Order is designed for multi-dimensional clustering. It can be applied for 1 column but it does not differ from normal sort. Calculating z-indices , ordering and rewriting files in case of compaction adds overhead without any value. So, it is not required to support for 1 column -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
