okumin opened a new pull request, #6122:
URL: https://github.com/apache/hive/pull/6122
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
Normalize the license headers. This pull request aligns the depth of indents.
This PR affects numerous files, but most changes are whitespace-only. So, I
recommend checking the diff with [the w=1
option](https://github.com/okumin/hive/pull/1/files?w=1) or `git diff
master...HIVE-29245-regex-indent -w`.
Originally, I attempted to update all at once in #6115, but it is likely to
be difficult to review. So, I created a separate pull request focusing on
whitespace changes.
### Why are the changes needed?
Our CI checks the license header format of new files. Some (or most) people
copy and paste the header from existing Java files. Unfortunately, existing
files don't share the same format, and SonarQube often reports a license issue.
A reviewer has to say "you must not copy and paste the header from existing
files, you must pick it up from
[checkstyle/asf.header](https://github.com/apache/hive/blob/master/checkstyle/asf.header).
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
I put the following configuration on `checkstyle/checkstyle.xml`,
`standalone-metastore/checkstyle/checkstyle.xml`, and
`storage-api/checkstyle/checkstyle.xml. After that, I ran `mvn
checkstyle:check`.
```xml
<?xml version="1.0"?>
<!DOCTYPE module PUBLIC
"-//Puppy Crawl//DTD Check Configuration 1.2//EN"
"http://www.puppycrawl.com/dtds/configuration_1_2.dtd";>
<module name="Checker">
<module name="RegexpHeader">
<property name="headerFile"
value="${config_loc}/asf.header.incremental"/>
<property name="fileExtensions" value="java"/>
<property name="multiLines" value="2"/>
</module>
</module>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
