deniskuzZ commented on code in PR #6090:
URL: https://github.com/apache/hive/pull/6090#discussion_r2378490856
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveTableUtil.java:
##########
@@ -171,11 +172,13 @@ public static void appendFiles(URI fromURI, String
format, Table icebergTbl, boo
if (isOverwrite) {
DeleteFiles delete = transaction.newDelete();
if (partitionSpec != null) {
+ Expression andResult = Expressions.alwaysTrue();
Review Comment:
could we rename local var to `partitionExpr` and use
`IcebergTableUtil.generateExpressionFromPartitionSpec(...)`?
````
if (partitionSpec != null) {
Expression partitionExpr =
IcebergTableUtil.generateExpressionFromPartitionSpec(icebergTbl, partitionSpec,
true);
delete.deleteFromRowFilter(partitionExpr);
} else {
delete.deleteFromRowFilter(Expressions.alwaysTrue());
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
