okumin commented on code in PR #6094:
URL: https://github.com/apache/hive/pull/6094#discussion_r2371166190
##########
itests/qtest-iceberg/src/test/java/org/apache/hadoop/hive/cli/TestIcebergRESTCatalogLlapLocalCliDriver.java:
##########
@@ -18,101 +18,159 @@
package org.apache.hadoop.hive.cli;
-import org.apache.commons.io.FileUtils;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.hive.cli.control.CliAdapter;
import org.apache.hadoop.hive.cli.control.CliConfigs;
-import org.apache.hadoop.hive.metastore.ServletSecurity;
import org.apache.hadoop.hive.metastore.conf.MetastoreConf;
import org.apache.hadoop.hive.ql.session.SessionState;
-import org.apache.hive.ITestsSchemaInfo;
import org.apache.iceberg.CatalogUtil;
import org.apache.iceberg.hive.CatalogUtils;
+import org.apache.iceberg.hive.client.HiveRESTCatalogClient;
+import org.junit.After;
import org.junit.Before;
import org.junit.ClassRule;
import org.junit.Rule;
import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
import org.junit.rules.TestRule;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import org.junit.runners.Parameterized.Parameters;
-import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import org.testcontainers.containers.BindMode;
+import org.testcontainers.containers.output.Slf4jLogConsumer;
+import org.testcontainers.containers.wait.strategy.Wait;
+import org.testcontainers.utility.DockerImageName;
+import org.testcontainers.utility.MountableFile;
+import org.testcontainers.containers.GenericContainer;
import java.io.File;
import java.io.IOException;
+import java.io.InputStream;
+import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.time.Duration;
import java.util.List;
-import java.util.stream.Stream;
@RunWith(Parameterized.class)
public class TestIcebergRESTCatalogLlapLocalCliDriver {
- private static final Logger LOG = LoggerFactory.getLogger(
-
org.apache.hadoop.hive.cli.TestIcebergRESTCatalogLlapLocalCliDriver.class);
+ private static final String GRAVITINO_CONF_TEMPLATE =
"gravitino-h2-test-template.conf";
+ private static final String GRAVITINO_CONF = "gravitino-h2-test.conf";
private static final String CATALOG_NAME = "ice01";
private static final CliAdapter adapter = new
CliConfigs.TestIcebergRESTCatalogLlapLocalCliDriver().getCliAdapter();
+ private static final DockerImageName GRAVITINO_IMAGE =
+ DockerImageName.parse("apache/gravitino-iceberg-rest:1.0.0-rc3");
Review Comment:
Just curious if the REST catalog of HMS does not work or not
##########
itests/qtest-iceberg/src/test/resources/gravitino-h2-test-template.conf:
##########
@@ -0,0 +1,14 @@
+gravitino.iceberg-rest.httpPort = 9001
+
+# --- Iceberg REST Catalog Backend (set to JDBC) ---
+gravitino.iceberg-rest.catalog-backend = jdbc
Review Comment:
The default backend is likely `memory`. Can't we use it? The `memory` mode
sounds like we don't need an additional dependency.
https://gravitino.apache.org/docs/0.9.1/iceberg-rest-service
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/MetastoreUtil.java:
##########
@@ -157,6 +159,8 @@ private static StorageDescriptor
getHiveStorageDescriptor(org.apache.iceberg.Tab
result.setSerdeInfo(getHiveSerdeInfo());
result.setLocation(table.location());
result.setParameters(Maps.newHashMap());
+ result.setSkewedInfo(new SkewedInfo(new SkewedInfo(Collections.emptyList(),
+ Collections.emptyList(), Collections.emptyMap())));
Review Comment:
Taking a glance, we don't need to wrap SkewedInfo with SkewedInfo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
