armitage420 commented on PR #6075: URL: https://github.com/apache/hive/pull/6075#issuecomment-3323394112
> > The masking is only done for HDFS paths, file_size_in_bytes and total file size of table properties, the masking doesn't really effect the validation of the test. > > @armitage420 test adds some additional masking as well, try removing and see for yourself. Why do we mask row count instead of size_in_bytes? https://iceberg.apache.org/docs/1.9.0/spark-queries/#all-data-files > > ``` > 0 hdfs://### HDFS PATH ### ORC 0 5 378 {1:7,2:30} > > 0 hdfs://### HDFS PATH ### ORC 0 #Masked# 378 {1:7,2:30} > ``` My bad, I have fixed the wrong masking related to file format. Although fixing this has no effect on the flaky nature of the test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
