zhangbutao commented on code in PR #6123:
URL: https://github.com/apache/hive/pull/6123#discussion_r2443046520
##########
parser/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g:
##########
@@ -1144,6 +1147,13 @@ catalogComment
-> ^(TOK_CATALOGCOMMENT $comment)
;
+catProperties
+@init { pushMsg("catproperties", state); }
+@after { popMsg(state); }
+ :
+ LPAREN dbPropertiesList RPAREN -> ^(TOK_CATALOGPROPERTIES
dbPropertiesList)
Review Comment:
Now `dbPropertiesList` is used by data connector & database & catalog. I
renamed `dbPropertiesList` to `propertiesList` to make this object more
generic.
##########
parser/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g:
##########
@@ -974,7 +974,7 @@ nonReserved
KW_ABORT | KW_ADD | KW_ADMIN | KW_AFTER | KW_ANALYZE | KW_ARCHIVE | KW_ASC
| KW_BEFORE | KW_BUCKET | KW_BUCKETS
| KW_CASCADE | KW_CBO | KW_CHANGE | KW_CHECK | KW_CLUSTER | KW_CLUSTERED |
KW_CLUSTERSTATUS | KW_COLLECTION | KW_COLUMNS
| KW_COMMENT | KW_COMPACT | KW_COMPACTIONS | KW_COMPUTE | KW_CONCATENATE |
KW_CONTINUE | KW_COST | KW_DATA | KW_DAY | KW_CATALOG | KW_CATALOGS
- | KW_DATABASES | KW_DATETIME | KW_DBPROPERTIES | KW_DCPROPERTIES |
KW_DEFERRED | KW_DEFINED | KW_DELIMITED | KW_DEPENDENCY
+ | KW_DATABASES | KW_DATETIME | KW_DBPROPERTIES | KW_DCPROPERTIES
|KW_PROPERTIES | KW_DEFERRED | KW_DEFINED | KW_DELIMITED | KW_DEPENDENCY
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
