dengzhhu653 commented on code in PR #6142:
URL: https://github.com/apache/hive/pull/6142#discussion_r2444582270
##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/MetastoreHousekeepingLeaderTestBase.java:
##########
@@ -54,19 +56,24 @@ class MetastoreHousekeepingLeaderTestBase {
static Map<String, Boolean> threadNames = new HashMap<>();
static Map<Class<? extends Thread>, Boolean> threadClasses = new HashMap<>();
- void internalSetup(final String leaderHostName, boolean configuredLeader)
throws Exception {
+ void internalSetup(final String leaderHostName, Configuration configuration)
throws Exception {
+ this.conf = configuration;
MetaStoreTestUtils.setConfForStandloneMode(conf);
MetastoreConf.setVar(conf, ConfVars.THRIFT_BIND_HOST, "localhost");
- MetastoreConf.setVar(conf,
ConfVars.METASTORE_HOUSEKEEPING_LEADER_HOSTNAME, leaderHostName);
MetastoreConf.setVar(conf, ConfVars.METASTORE_HOUSEKEEPING_LEADER_ELECTION,
- configuredLeader ? "host" : "lock");
+ leaderHostName != null ? "host" : "lock");
+ if (leaderHostName != null) {
+ MetastoreConf.setVar(conf,
ConfVars.METASTORE_HOUSEKEEPING_LEADER_HOSTNAME, leaderHostName);
+ }
MetastoreConf.setBoolVar(conf,
MetastoreConf.ConfVars.COMPACTOR_INITIATOR_ON, true);
MetastoreConf.setBoolVar(conf,
MetastoreConf.ConfVars.COMPACTOR_CLEANER_ON, true);
addHouseKeepingThreadConfigs();
warehouse = new Warehouse(conf);
+ conf.set("metastore.leader.test.listener",
TestLeaderNotification.class.getName());
Review Comment:
This property is for test only, it's shouldn't be exposed to user or else
where in the unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
