simhadri-g commented on code in PR #6127:
URL: https://github.com/apache/hive/pull/6127#discussion_r2448737447
##########
.github/workflows/docker-GA-images.yml:
##########
@@ -153,23 +99,13 @@ jobs:
file: ./packaging/src/docker/Dockerfile
platforms: linux/amd64,linux/arm64
push: true
- tags: apache/hive:${{ env.tag }}
+ tags: ${{ env.namespace }}/hive:${{ env.tag }}
Review Comment:
This is what i was referring to (found the exact jira):
https://issues.apache.org/jira/browse/HIVE-27277?focusedCommentId=17759033&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17759033
PR:
https://github.com/apache/hive/commit/474c2e27e0b9715e3065a7f1a84cc1186f67d2ed
So i was using `tags: ${{ secrets.DOCKERHUB_USER }}/hive:${{ env.tag }}`
secrets.DOCKERHUB_USER should ideally be the repo name which is "apache" but it
turns out its "afsjenkins" when building. My bad , was a little confused with
the environment variable is used .
So just wanted to make sure we are not running into a similar issue again.
Apart for this, rest of the PR LGTM +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
