deniskuzZ commented on code in PR #6123:
URL: https://github.com/apache/hive/pull/6123#discussion_r2451854384
##########
parser/src/java/org/apache/hadoop/hive/ql/parse/AlterClauseParser.g:
##########
@@ -161,6 +161,14 @@ alterCatalogStatementSuffix
@init { gParent.pushMsg("alter catalog statement", state); }
@after { gParent.popMsg(state); }
: alterCatalogSuffixSetLocation
+ | alterCatalogSuffixProperties
+ ;
+
+alterCatalogSuffixProperties
+@init { gParent.pushMsg("alter catalog properties statement", state); }
+@after { gParent.popMsg(state); }
+ : name=identifier KW_SET KW_PROPERTIES properties
Review Comment:
oh, i didn't realize that we use resource specific property naming (i.e
`alter database db1 set dbproperties('key'='value')`)
> I prefer using just KW_PROPERTIES (properties) since the keyword
catproperties is too dialect-specific.
ok, however, can we use KW_CATPROPERTIES token instead, to be consistent
with prev namings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
