kokila-19 commented on code in PR #6138:
URL: https://github.com/apache/hive/pull/6138#discussion_r2459976280
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/InputFormatConfig.java:
##########
@@ -78,6 +78,9 @@ private InputFormatConfig() {
public static final String CATALOG_CONFIG_PREFIX = "iceberg.catalog.";
+ public static final String SORT_ORDER = "sort.order";
Review Comment:
I agree semantically sort.type would be clearer than sort.order
` it's only internal config that is not shared.`
Impala uses sort.order and sort.columns in HMS table properties to store
sort order details and Hive now does the same.
To maintain future cross-engine compatibility for Z-order writes, I have
followed the same convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
