thomasrebele commented on code in PR #6103:
URL: https://github.com/apache/hive/pull/6103#discussion_r2473010022


##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java:
##########
@@ -182,6 +184,7 @@ protected TrimResult trimChild(
       RelNode input,
       final ImmutableBitSet fieldsUsed,
       Set<RelDataTypeField> extraFields) {
+    setColumnAccessInfoForViews(rel, fieldsUsed);

Review Comment:
   The new way to call `setColumnAccessInfoForViews` is better. It's the first 
method called in `dispatchTrimFields`, and `dispatchTrimFields` is called for 
all nodes including the root.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to