deniskuzZ commented on code in PR #6143:
URL: https://github.com/apache/hive/pull/6143#discussion_r2477955539
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MergeCompactor.java:
##########
@@ -56,8 +56,8 @@ public boolean run(CompactorContext context) throws
IOException, HiveException,
if (isMergeCompaction(hiveConf, dir, storageDescriptor)) {
// Only inserts happened, it is much more performant to merge the files
than running a query
- Path outputDirPath = getOutputDirPath(hiveConf, writeIds,
- compactionInfo.isMajorCompaction(), storageDescriptor);
+ Path outputDirPath =
QueryCompactor.Util.getCompactionResultDir(storageDescriptor, writeIds,
Review Comment:
isn't `bucket0` always false? could we drop it?
ps: please run optimize imports on `QueryCompactor` to remove unused ones
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
