kuczoram commented on code in PR #6154:
URL: https://github.com/apache/hive/pull/6154#discussion_r2495288441
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/functions/CommitTxnFunction.java:
##########
@@ -235,12 +245,11 @@ public TxnType execute(MultiDataSourceJdbcResource
jdbcResource) throws MetaExce
throw new TxnAbortedException(msg);
}
}
- } else if (!TxnHandler.ConfVars.useMinHistoryLevel()) {
- jdbcResource.getJdbcTemplate().update(writeSetInsertSql + "FROM
\"TXN_COMPONENTS\" WHERE \"TC_TXNID\" = :txnId AND \"TC_OPERATION_TYPE\" <>
:type",
+ } else if (!ConfVars.useMinHistoryLevel()) {
+ jdbcResource.getJdbcTemplate().update(writeSetInsertSql + "FROM
\"TXN_COMPONENTS\" WHERE \"TC_TXNID\" = :txnId",
new MapSqlParameterSource()
.addValue("txnId", txnid)
- .addValue("type", OperationType.COMPACT.getSqlConst()));
- commitId = jdbcResource.execute(new GetHighWaterMarkHandler());
+ .addValue("commitId", txnid));
Review Comment:
Just one question. Why did you set the txnId as commitId here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
