dengzhhu653 commented on PR #6159:
URL: https://github.com/apache/hive/pull/6159#issuecomment-3527187344
> in any case, solution in this PR is acceptable and OK to merge, but please
consider using MVCC (i.e. `updateParameterWithExpectedValue`) since it's
already used (please see comment above).
>
> Another question: since we’re adding `RetryingExecutor` here, what’s the
role of `RetryingMetaStoreClient`? Doesn’t it already handle the same
functionality?
`RetryingMetaStoreClient` basically retries the call on thrift lawyer
exception, such as service shutdown(connection refused or timeout), or
incompatible protocol(connect to an old HMS which thrift method hasn't been
introduced).
`RetryingExecutor` doesn't need a tcp round trip, it's more efficient than
`RetryingMetaStoreClient`, i.e, no need to serialize or de-serialize the thrift
message and convey the message over the connection.
IMO in the MVCC the transaction still holds the row lock in case of affected
rows = 1, it might be rolled back in the middle of the transaction, so other
updates need this transaction to commit or rollback to make sure to get the
right version of this row.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
