csringhofer commented on PR #6201: URL: https://github.com/apache/hive/pull/6201#issuecomment-3553225759
Thanks for quickly fixing this! Do you plan to upload the change or create an issue to https://github.com/Esri/spatial-framework-for-hadoop ? It could be referenced in the commit message or the Jira. About "in the affected getInferredOGCType method I cannot see "linestring", only "ST_MULTILINESTRING", ": There is getPathCount() in MultiPath, which is the base class of Polyline https://github.com/Esri/geometry-api-java/blob/020a1a9f6e1126663a0a669095e61d265ca95019/src/main/java/com/esri/core/geometry/MultiPath.java#L501 This could be used to differentiate linestring and multilinestring, but I don't know if there is any code currently that will exercise this (maybe st_union?) My impression is that the current st_convexhull() handles the "degenerate cases" (what would result in point or line) differently than postgis. This is not a big issue IMO as these results are not that useful anyway. Btw I looked at a few similar queries and other functions also return different types based on the actual geometry, e.g. st_difference also checks whether the result is a single or multiple polygons: select st_astext(st_difference(st_geomfromtext("polygon((0 0, 2 0, 2 2, 0 2))"), st_geomfromtext("polygon((0 0, 1 0, 1 1, 0 1))"))); >POLYGON ((1 0, 2 0, 2 2, 0 2, 0 1, 1 1, 1 0)) select st_astext(st_difference(st_geomfromtext("polygon((0 0, 3 0, 3 3, 0 3))"), st_geomfromtext("polygon((1 0, 2 0, 2 3, 1 3))"))); >MULTIPOLYGON (((0 0, 1 0, 1 3, 0 3, 0 0)), ((2 0, 3 0, 3 3, 2 3, 2 0))) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
