Aggarwal-Raghav commented on code in PR #6206:
URL: https://github.com/apache/hive/pull/6206#discussion_r2549367185
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HiveSplitGenerator.java:
##########
@@ -303,17 +303,14 @@ public List<Event> initialize() throws Exception {
int availableSlots = getAvailableSlotsCalculator().getAvailableSlots();
- if (HiveConf.getLongVar(conf, HiveConf.ConfVars.MAPRED_MIN_SPLIT_SIZE,
1) <= 1) {
- // broken configuration from mapred-default.xml
- final long blockSize =
conf.getLongBytes(DFSConfigKeys.DFS_BLOCK_SIZE_KEY,
- DFSConfigKeys.DFS_BLOCK_SIZE_DEFAULT);
- final long minGrouping = conf.getLong(
- TezMapReduceSplitsGrouper.TEZ_GROUPING_SPLIT_MIN_SIZE,
- TezMapReduceSplitsGrouper.TEZ_GROUPING_SPLIT_MIN_SIZE_DEFAULT);
- final long preferredSplitSize = Math.min(blockSize / 2, minGrouping);
- HiveConf.setLongVar(jobConf,
HiveConf.ConfVars.MAPRED_MIN_SPLIT_SIZE, preferredSplitSize);
- LOG.info("The preferred split size is " + preferredSplitSize);
- }
+ final long blockSize =
conf.getLongBytes(DFSConfigKeys.DFS_BLOCK_SIZE_KEY,
+ DFSConfigKeys.DFS_BLOCK_SIZE_DEFAULT);
+ final long minGrouping = conf.getLong(
+ TezMapReduceSplitsGrouper.TEZ_GROUPING_SPLIT_MIN_SIZE,
+ TezMapReduceSplitsGrouper.TEZ_GROUPING_SPLIT_MIN_SIZE_DEFAULT);
+ final long preferredSplitSize = Math.min(blockSize / 2, minGrouping);
+ HiveConf.setLongVar(jobConf, HiveConf.ConfVars.MAPRED_MIN_SPLIT_SIZE,
preferredSplitSize);
Review Comment:
Shouldn't the same config be removed from Line 312 as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
