okumin commented on code in PR #6207:
URL: https://github.com/apache/hive/pull/6207#discussion_r2551566289
##########
itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestHS2AuthMechsWithMiniKdc.java:
##########
@@ -87,7 +87,7 @@ public class TestHS2AuthMechsWithMiniKdc extends
AbstractLdapTestUnit {
@Before
public void setUpBefore() throws Exception {
if (miniHS2 == null) {
- Class.forName(MiniHS2.getJdbcDriverName());
+
Review Comment:
```suggestion
```
An extra line has been added to some files and not been added to some files.
I prefer to have no extra lines consistently
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/NoPoolConnectionPool.java:
##########
@@ -71,20 +72,6 @@ public Connection getConnection(String username, String
password) throws SQLExce
LOG.error(msg);
throw new RuntimeException(msg);
}
- try {
- LOG.info("Going to load JDBC driver {}", driverName);
- driver = (Driver) Class.forName(driverName).newInstance();
Review Comment:
This might change the behavior of L67 because `this.driver` is never
assigned now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
