mdayakar commented on code in PR #6204:
URL: https://github.com/apache/hive/pull/6204#discussion_r2556019628
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/constraint/ConstraintsUtils.java:
##########
@@ -309,8 +312,8 @@ private static List<ConstraintInfo>
generateConstraintInfos(ASTNode child, List<
* @param node AST node corresponding to default value
* @return retrieve the default value and return it as string
*/
- private static Pair<TypeInfo, String> getDefaultValueAndType(ASTNode node,
TokenRewriteStream tokenStream)
- throws SemanticException{
+ private static Pair<TypeInfo, String> getDefaultValueAndType(ASTNode node,
TokenRewriteStream tokenStream,
+ boolean isNegativeConstant) throws SemanticException {
// first create expression from defaultValueAST
TypeCheckCtx typeCheckCtx = new TypeCheckCtx(null);
ExprNodeDesc defaultValExpr = ExprNodeTypeCheck.genExprNode(node,
typeCheckCtx).get(node);
Review Comment:
Yeah, after changing the grammar file, now `-` sign is the parent of `15` so
removed the `isNegativeConstant` variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
