difin commented on code in PR #6184: URL: https://github.com/apache/hive/pull/6184#discussion_r2560855429
########## ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/order/AlterTableSetWriteZOrderDesc.java: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.ql.ddl.table.storage.order; + +import java.util.Map; + +import org.apache.hadoop.hive.common.TableName; +import org.apache.hadoop.hive.metastore.api.EnvironmentContext; +import org.apache.hadoop.hive.ql.ddl.table.AbstractAlterTableDesc; +import org.apache.hadoop.hive.ql.ddl.table.AlterTableType; +import org.apache.hadoop.hive.ql.parse.SemanticException; +import org.apache.hadoop.hive.ql.plan.Explain; +import org.apache.hadoop.hive.ql.plan.Explain.Level; + +/** + * DDL task description for ALTER TABLE ... SET WRITE [LOCALLY] ORDERED BY ZORDER(...) commands. + */ +@Explain(displayName = "Set Write ZOrder", explainLevels = { Level.USER, Level.DEFAULT, Level.EXTENDED }) +public class AlterTableSetWriteZOrderDesc extends AbstractAlterTableDesc { + private static final long serialVersionUID = 1L; + + public AlterTableSetWriteZOrderDesc(TableName tableName, Map<String, String> partitionSpec, + Map<String, String> props) throws SemanticException { + super(AlterTableType.ADDPROPS, tableName, partitionSpec, null, false, false, props); + } + + @Override + public EnvironmentContext getEnvironmentContext() { + return null; + } Review Comment: This method is same as its parent `AbstractAlterTableDesc.getEnvironmentContext()`, looks like the override is not needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
