deniskuzZ commented on PR #6152: URL: https://github.com/apache/hive/pull/6152#issuecomment-3580438401
> I tested variant_type_shredding.q by removing 'variant.shredding.enabled'='true' from the table properties, and the qtest still passes without any failures. This test verifies that basic INSERT/SELECT operations succeed with VARIANT columns but not actual shredding in the file. This testing is not possible in qtest. > > so maybe we can add a JUnit test (e.g., TestVariantShredding) that: Writes VARIANT data with variant.shredding.enabled=true and false Opens the resulting Parquet files via ParquetFileReader Asserts that the typed_value field is present/absent accordingly that test was added in iceberg: [Expose variantShreddingFunc() in Parquet.DataWriteBuilder](https://github.com/apache/iceberg/commit/df01d88c9360cda398c40493eb4135181a8976c5#diff-527c8da87c985dd300783e80186f146157ef0bd3715fbbf0b7b0ae7eb5e482db) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
