Aggarwal-Raghav commented on code in PR #6181:
URL: https://github.com/apache/hive/pull/6181#discussion_r2564336759
##########
ql/pom.xml:
##########
@@ -1057,6 +1057,7 @@
<include>org.apache.thrift:libthrift</include>
<include>org.apache.thrift:libfb303</include>
<include>org.datanucleus:javax.jdo</include>
+ <include>commons-collections:commons-collections</include>
Review Comment:
Sure. But just want to highlight that commons-lang 2.x and 3.x are shipped
even commons-lang2.x is banned import in parent pom.xml. But cleanup of this
shading is separate issue.
My thinking was to updated the imports to commons-collections4.x like
https://github.com/apache/hive/pull/5588 and shade commons-collections3.x in ql
pom.xml + add TODO statement :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
