zhangbutao commented on code in PR #6088:
URL: https://github.com/apache/hive/pull/6088#discussion_r2564520075
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -1297,7 +1303,12 @@ public void renamePartition(Table tbl, Map<String,
String> oldPartSpec, Partitio
}
}
- // TODO: this whole path won't work with catalogs
+ /**
+ * When you call this method, you need to ensure that the catalog has been
set in the db object.
Review Comment:
https://github.com/apache/hive/pull/6088/files#diff-0b11c3fb6f813b496b291de76cbdf98dff3e7f47d1ba4d8bb68c4dedb858da42R516
In this method, the call to` BaseMetaStoreClient::alterDatabase(String name,
Database db)` will retrieve the specific catalog name based on the current
session or the db object.
However, we need to ensure that the db object preferably contains the
catalog name, because references in the format "cat.db" might be unrelated to
the current session's catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
