deniskuzZ commented on code in PR #5751:
URL: https://github.com/apache/hive/pull/5751#discussion_r2572199805
##########
iceberg/pom.xml:
##########
@@ -305,23 +305,19 @@
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<fork>true</fork>
+ <proc combine.self="override"/>
<showWarnings>true</showWarnings>
<compilerArgs>
<arg>-XDcompilePolicy=simple</arg>
<arg>-Xplugin:ErrorProne -Xep:BanSerializableRead:WARN</arg>
<arg>-J-Xbootclasspath/p:${settings.localRepository}/com/google/errorprone/javac/${google.errorprone.javac.version}/javac-${google.errorprone.javac.version}.jar</arg>
</compilerArgs>
- <annotationProcessorPaths>
+ <annotationProcessorPaths combine.children="append">
<path>
<groupId>com.google.errorprone</groupId>
<artifactId>error_prone_core</artifactId>
<version>${google.errorprone.version}</version>
</path>
- <dependency>
Review Comment:
we should probably move the `error_prone_annotations` to iceberg-catalog as
well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]