Aggarwal-Raghav commented on code in PR #6217:
URL: https://github.com/apache/hive/pull/6217#discussion_r2576783180


##########
.github/workflows/docker-GA-images.yml:
##########
@@ -62,9 +62,11 @@ jobs:
         uses: actions/checkout@v3
 
       - name: 'Set up JDK 21'
-        uses: actions/setup-java@v1
+        uses: actions/setup-java@v5
         with:
-          java-version: 21
+          java-version: '21'
+          distribution: temurin
+          cache: maven

Review Comment:
   Given that this workflow is triggered only upon new releases, is a 3-month 
cache retention necessary? I’ve previously encountered issues with 
`maven-metadata.xml` when multiple runs update the same .m2 cache. While that 
specific scenario might not apply here, I am unclear on the value this cache 
adds given the infrequent trigger schedule.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to