deniskuzZ commented on code in PR #6161:
URL: https://github.com/apache/hive/pull/6161#discussion_r2593961771
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java:
##########
@@ -292,12 +291,37 @@ protected void openInternal(String[]
additionalFilesNotFromConf,
LOG.info("Created new resources: " + this.resources);
}
- // unless already installed on all the cluster nodes, we'll have to
- // localize hive-exec.jar as well.
+ // Unless already installed on all the cluster nodes, we'll have to
localize hive-exec.jar as well.
appJarLr = createJarLocalResource(utils.getExecJarPathLocal(conf));
- // configuration for the application master
- final Map<String, LocalResource> commonLocalResources = new
HashMap<String, LocalResource>();
+ try {
+ openInternalUnsafe(isAsync, console);
+ } catch (Exception e) {
+ LOG.info("Failed to open session, deleting scratch dir to prevent
resource leak...", e);
+ cleanupScratchDir();
+ throw e;
+ }
+ }
+
+ /**
+ * Opens a Tez session without performing a complete rollback/cleanup on
failure.
+ *
+ * <p><strong>Callers MUST guard this method with try/catch and perform
cleanup</strong>
+ * of partially initialized state (such as localized files in the scratch
directory).
+ * This method is not safe on its own.</p>
+ *
+ * @param isAsync whether to open the Tez session asynchronously in a
separate thread
+ * @param console a {@link LogHelper} used to log session startup events
+ *
+ * @throws TezException if the session fails to start (including failures
during
+ * container launch or session initialization)
+ * @throws IOException if local resource localization or I/O setup fails
+ */
+ @VisibleForTesting
+ void openInternalUnsafe(boolean isAsync, LogHelper console) throws
TezException, IOException {
Review Comment:
why not use protected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
