aturoczy commented on code in PR #6227:
URL: https://github.com/apache/hive/pull/6227#discussion_r2600231976
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -494,7 +494,7 @@ public void createNamespace(Namespace namespace,
Map<String, String> meta) {
@Override
public List<Namespace> listNamespaces(Namespace namespace) {
- if (!isValidateNamespace(namespace) && !namespace.isEmpty()) {
+ if (!namespace.isEmpty() && (!isValidateNamespace(namespace) ||
!namespaceExists(namespace))) {
Review Comment:
namespaceExists imho should be handle the isEmpty() scenario, and in this
case there would not need another condition in the if statement
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HMSTablePropertyHelper.java:
##########
@@ -168,8 +196,7 @@ private static void setCommonParameters(
setSchema(schema, parameters, maxHiveTablePropertySize);
}
- @VisibleForTesting
- static void setStorageHandler(Map<String, String> parameters, boolean
hiveEngineEnabled) {
+ private static void setStorageHandler(Map<String, String> parameters,
boolean hiveEngineEnabled) {
Review Comment:
Does not need to be public for testing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
