kokila-19 commented on code in PR #6184: URL: https://github.com/apache/hive/pull/6184#discussion_r2600959441
########## iceberg/iceberg-handler/src/test/queries/positive/iceberg_alter_locally_zordered_table.q: ########## @@ -0,0 +1,40 @@ +-- Mask neededVirtualColumns due to non-strict order +--! qt:replace:/(\s+neededVirtualColumns:\s)(.*)/$1#Masked#/ +-- Mask the totalSize value as it can have slight variability, causing test flakiness +--! qt:replace:/(\s+totalSize\s+)\S+(\s+)/$1#Masked#$2/ +-- Mask random uuid +--! qt:replace:/(\s+uuid\s+)\S+(\s*)/$1#Masked#$2/ +-- Mask a random snapshot id +--! qt:replace:/(\s+current-snapshot-id\s+)\S+(\s*)/$1#Masked#/ +-- Mask added file size +--! qt:replace:/(\S\"added-files-size\\\":\\\")(\d+)(\\\")/$1#Masked#$3/ +-- Mask total file size +--! qt:replace:/(\S\"total-files-size\\\":\\\")(\d+)(\\\")/$1#Masked#$3/ +-- Mask removed file size +--! qt:replace:/(\S\"removed-files-size\\\":\\\")(\d+)(\\\")/$1#Masked#$3/ +-- Mask current-snapshot-timestamp-ms +--! qt:replace:/(\s+current-snapshot-timestamp-ms\s+)\S+(\s*)/$1#Masked#$2/ +--! qt:replace:/(MAJOR\s+succeeded\s+)[a-zA-Z0-9\-\.\s+]+(\s+manual)/$1#Masked#$2/ +-- Mask iceberg version +--! qt:replace:/(\S\"iceberg-version\\\":\\\")(\w+\s\w+\s\d+\.\d+\.\d+\s\(\w+\s\w+\))(\\\")/$1#Masked#$3/ +set hive.llap.io.enabled=true; +set hive.vectorized.execution.enabled=true; +set hive.optimize.shared.work.merge.ts.schema=true; + +-- Test ALTER TABLE SET WRITE [LOCALLY] ORDERED BY ZORDER +create table ice_orc_zorder (id int, name string, age int, city string) stored by iceberg stored as orc; + +describe formatted ice_orc_zorder; + +explain insert into ice_orc_zorder values (1, 'Alice', 30, 'NYC'),(2, 'Bob', 25, 'LA'),(3, 'Charlie', 35, 'SF'); + +-- Add Z-order via ALTER TABLE with LOCALLY keyword +alter table ice_orc_zorder set WRITE LOCALLY ORDERED BY ZORDER (id, age); Review Comment: `LOCALLY` was the required syntax for regular ordering before Z-order support was introduced. Because write ordering applies only to the data added in each individual INSERT query, this behaviour was originally tied to the `LOCALLY` keyword. As the functionality expanded and additional engines were considered, we made this requirement `optional` when Z-order was added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
