InvisibleProgrammer commented on code in PR #6219:
URL: https://github.com/apache/hive/pull/6219#discussion_r2601662526
##########
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRecordUpdater.java:
##########
@@ -93,12 +93,12 @@ public class OrcRecordUpdater implements RecordUpdater {
static final String CURRENT_WRITEID_FIELD_NAME = "currentTransaction";
static final String ROW_FIELD_NAME = "row";
public static final Collection<String> ALL_ACID_ROW_NAMES = Arrays.asList(
- OrcRecordUpdater.BUCKET_FIELD_NAME,
- OrcRecordUpdater.CURRENT_WRITEID_FIELD_NAME,
- OrcRecordUpdater.ORIGINAL_WRITEID_FIELD_NAME,
- OrcRecordUpdater.OPERATION_FIELD_NAME,
- OrcRecordUpdater.ROW_FIELD_NAME,
- OrcRecordUpdater.ROW_ID_FIELD_NAME);
+ OrcRecordUpdater.BUCKET_FIELD_NAME.toLowerCase(),
Review Comment:
<img width="780" height="357" alt="image"
src="https://github.com/user-attachments/assets/f631a07f-b459-4895-9baf-f2e9bf006b25";
/>
The collection itself is used only at one place. The constants are being
used at multiple places. The problem is the values shouldn't be lowercase but
the specification doesn't explicitly say anything about the casing.
With that ticket we enable flows that would fail if we receive an orc file
when this metadata keys are lower cased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
