zabetak opened a new pull request, #6230: URL: https://github.com/apache/hive/pull/6230
### What changes were proposed in this pull request? 1. Add new property to control indentation of EXPLAIN FORMATTED result 2. Create the appropriate JsonParser in ExplainTask based on explain configurations 3. Drop now unused and redundant JsonParserFactory 4. Extract logic for augmenting RS outputs in separate method dedicated for this purpose ### Why are the changes needed? 1. Improve readability of EXPLAIN FORMATTED result in qtest 2. Avoid unnecessary masking in q.out files 3. Speed-up processing of files by QOutProcessor (shorter lines -> more efficient pattern matching) 4. Better git utilization (history, log, blame, merge, rebase, etc.) ### Does this PR introduce _any_ user-facing change? No, unless they change the value of `hive.explain.formatted.indent` property. ### How was this patch tested? ```shell mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile=plan_json.q,excluded_rule_explain.q,materialized_view_rebuild_2.q,ctas.q,input4.q,join0.q,vector_outer_join5.q,vector_outer_join4.q,materialized_view_create.q,explain_ast.q,explain_locks.q,cte_cbo_plan_json.q,authorization_explain.q,concat_op.q,vector_outer_join3.q,tez_union.q,parallel_join0.q,vector_outer_join6.q,explain_dependency.q,explain_dependency2.q,explaindenpendencydiffengs.q mvn test -Dtest=TestIcebergCliDriver -Dqfile=iceberg_explain_formatted.q ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
