difin commented on code in PR #6218:
URL: https://github.com/apache/hive/pull/6218#discussion_r2604708898
##########
data/conf/iceberg/llap/hive-site.xml:
##########
@@ -397,4 +397,9 @@
<name>hive.lock.sleep.between.retries</name>
<value>2</value>
</property>
+
+ <property>
+ <name>write.metadata.delete-after-commit.enabled</name>
Review Comment:
Manifest caching configs in Hive already support being set in session conf
with the same catalog prefix as the RESTCatalog configs -
`iceberg.catalog-default.` or `iceberg.catalog.<name>.` :
https://github.com/apache/hive/blob/742ea4f5152f1fa910c015c03ba904da1bb4a9e6/iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/TestCatalogs.java#L269-L273
Can we keep the existing prefix approach for consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
