deniskuzZ commented on code in PR #6088:
URL: https://github.com/apache/hive/pull/6088#discussion_r2606744513
##########
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java:
##########
@@ -380,7 +389,7 @@ private HiveLockMode getWriteEntityLockMode (WriteEntity
we) {
}
}
- private List<HiveLockObj> getLockObjects(QueryPlan plan, Database db,
+ private List<HiveLockObj> getLockObjects(QueryPlan plan, Catalog catalog,
Database db,
Review Comment:
could we make method generic:
````
private <T> List<HiveLockObj> getLockObjects(QueryPlan plan, T target,
HiveLockMode mode)
throws LockException {
List<HiveLockObj> locks = new LinkedList<HiveLockObj>();
switch (target) {
case Catalog catalog -> {
locks.add(new HiveLockObj(new HiveLockObject(catalog.getName(),
lockData), mode));
}
case Database db -> {
String catName = Objects.requireNonNullElse(db.getCatalogName(),
HiveUtils.getCurrentCatalogOrDefault(conf));
locks.add(new HiveLockObj(new HiveLockObject(catName, lockData), mode));
db.setCatalogName(catName);
locks.add(new HiveLockObj(new HiveLockObject(db, lockData), mode));
}
...
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
