difin commented on code in PR #6218:
URL: https://github.com/apache/hive/pull/6218#discussion_r2607450984
##########
data/conf/iceberg/llap/hive-site.xml:
##########
@@ -397,4 +397,9 @@
<name>hive.lock.sleep.between.retries</name>
<value>2</value>
</property>
+
+ <property>
+ <name>write.metadata.delete-after-commit.enabled</name>
Review Comment:
Hi @deniskuzZ,
I checked that if you set set following configs in Hive session:
```
'iceberg.catalog-default.write.metadata.delete-after-commit.enabled'='true'
'iceberg.catalog-default.write.metadata.previous-versions-max'='100'
```
or
```
'iceberg.catalog.<CATALOG_NAME>.write.metadata.delete-after-commit.enabled'='true'
'iceberg.catalog.<CATALOG_NAME>.write.metadata.previous-versions-max'='100'
```
They do propagate to iceberg catalog properties as:
```
'write.metadata.delete-after-commit.enabled'='true'
'write.metadata.previous-versions-max'='100'
```
This is the same behavior as other iceberg catalog properties like `uri`,
`type`, etc which are used for configuring the catalog. **But when these
configs are set on catalog level, they don't make any effect.** They need to be
set on table level to take effect.
So, because the configs from session don't propagate to iceberg table
properties we need the changes like `setWriteMetadataCleanupProperties`. I made
the changes that you wanted - to support these configs in hive session:
```
'iceberg.write.metadata.delete-after-commit.enabled'='true'
'iceberg.write.metadata.previous-versions-max'='100'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
