saihemanth-cloudera commented on code in PR #5851:
URL: https://github.com/apache/hive/pull/5851#discussion_r2612267877
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
##########
@@ -3380,8 +4765,68 @@ public GetAllFunctionsResponse getAllFunctions() throws
TException {
return client.get_all_functions();
}
+ protected void create_table(CreateTableRequest request) throws TException {
+ client.create_table_req(request);
+ }
+
+ protected void drop_table_with_environment_context(String catName, String
dbname, String name,
+ boolean deleteData, EnvironmentContext envContext) throws TException {
+ DropTableRequest dropTableReq = new DropTableRequest(dbname, name);
+ dropTableReq.setDeleteData(deleteData);
+ dropTableReq.setCatalogName(catName);
+ dropTableReq.setDropPartitions(true);
+ dropTableReq.setEnvContext(envContext);
+ dropTableReq.setAsyncDrop(!isLocalMetaStore());
+ TableOpResp resp = client.drop_table_req(dropTableReq);
+ dropTableReq.setId(resp.getId());
+ try {
+ while (!resp.isFinished() && !Thread.currentThread().isInterrupted()) {
Review Comment:
Should we add a timeout? Otherwise, we would repeatedly hammer HMS about
dropping the table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
