deniskuzZ commented on code in PR #6218:
URL: https://github.com/apache/hive/pull/6218#discussion_r2616152502
##########
iceberg/iceberg-handler/src/test/results/positive/show_iceberg_materialized_views.q.out:
##########
@@ -366,6 +366,8 @@ Table Parameters:
bucketing_version 2
current-schema
{\"type\":\"struct\",\"schema-id\":0,\"fields\":[{\"id\":1,\"name\":\"key\",\"required\":false,\"type\":\"int\"},{\"id\":2,\"name\":\"value\",\"required\":false,\"type\":\"string\"},{\"id\":3,\"name\":\"ds\",\"required\":false,\"type\":\"string\"}]}
format-version 1
+ iceberg.disable.vectorization.test1.shtb_test1 true
Review Comment:
this is overloaded in my opinion
````
// disabling VectorizedSupport.Support.DECIMAL_64 for Parquet as it doesn't
support it
boolean isORCOnly =
Boolean.parseBoolean(tableDesc.getProperties().getProperty(HiveIcebergMetaHook.DECIMAL64_VECTORIZATION))
&&
Boolean.parseBoolean(tableDesc.getProperties().getProperty(HiveIcebergMetaHook.ORC_FILES_ONLY))
&&
org.apache.iceberg.FileFormat.ORC.name()
.equalsIgnoreCase(tableDesc.getProperties().getProperty(TableProperties.DEFAULT_FILE_FORMAT));
if (!isORCOnly) {
final String vectorizationConfName =
getVectorizationConfName(tableDesc.getTableName());
LOG.debug("Setting {} for table: {} to true", vectorizationConfName,
tableDesc.getTableName());
hiveConf.set(vectorizationConfName, "true");
return new VectorizedSupport.Support[] {};
}
return new VectorizedSupport.Support[] {
VectorizedSupport.Support.DECIMAL_64 };
````
why not simply set
````
HIVE_VECTORIZED_INPUT_FORMAT_SUPPORTS_ENABLED(
"hive.vectorized.input.format.supports.enabled",
"decimal_64",
```` in table properties?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
