ayushtkn commented on code in PR #6245:
URL: https://github.com/apache/hive/pull/6245#discussion_r2634761450
##########
iceberg/iceberg-handler/src/test/queries/positive/variant_type_shredding.q:
##########
@@ -27,13 +27,30 @@ INSERT INTO tbl_shredded_variant VALUES
(2, parse_json('{"name": "Bill", "active": false}')),
(3, parse_json('{"name": "Henry", "age": 20}'));
--- Disable vectorized execution until Variant type is supported
-set hive.vectorized.execution.enabled=false;
-
-- Retrieve and verify
SELECT id, try_variant_get(data, '$.name') FROM tbl_shredded_variant
WHERE variant_get(data, '$.age') > 25;
EXPLAIN
SELECT id, try_variant_get(data, '$.name') FROM tbl_shredded_variant
WHERE variant_get(data, '$.age') > 25;
+
+CREATE TABLE t (
+ id INT,
+ v VARIANT
+)
+STORED BY ICEBERG
+TBLPROPERTIES (
+ 'format-version'='3',
+ 'variant.shredding.enabled'='true'
+);
+
+INSERT INTO t VALUES
+(1, parse_json('{"a": 1}')),
+(2, parse_json('{"b": 2}'));
+
+SELECT
Review Comment:
earlier it was giving wrong results:
```
NULL 2
NULL NULL
```
now it is correct, I added the scenario that I tried in
https://github.com/apache/hive/pull/6152#discussion_r2616169801
I didn't put like all cases to show output is same, just it is correct, the
previous original case was throwing exception, this was giving wrong result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
