saihemanth-cloudera commented on code in PR #5851:
URL: https://github.com/apache/hive/pull/5851#discussion_r2658343398
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -1104,17 +1108,11 @@ private void dropCatalogCore(String catName, boolean
ifExists)
req.setCatalogName(catName);
req.setDeleteData(true);
req.setCascade(false);
-
- drop_database_core(ms, req);
+ drop_database_req(req);
} catch (InvalidOperationException e) {
// This means there are tables of something in the database
throw new InvalidOperationException("There are still objects in
the default " +
"database for catalog " + catName);
Review Comment:
nit: should we also throw stack trace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
