dengzhhu653 commented on code in PR #5851:
URL: https://github.com/apache/hive/pull/5851#discussion_r2678282903
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -4528,23 +3571,30 @@ public AddPartitionsResult
add_partitions_req(AddPartitionsRequest request)
// Make sure all the partitions have the catalog set as well
request.getParts().forEach(p -> p.setCatName(catName));
request.setCatName(catName);
- List<Partition> parts = add_partitions_core(getMS(), request);
- if (request.isNeedResult()) {
+ AddPartitionsHandler addPartsOp = AbstractOperationHandler.offer(this,
request);
+ if (addPartsOp.success() && request.isNeedResult()) {
+ AddPartitionsHandler.AddPartitionsResult addPartsResult =
addPartsOp.getResult();
Review Comment:
no enough, the `addPartsOp.success()` need to check on the state(success or
not) of `addPartsOp.getResult()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
