kokila-19 commented on code in PR #6263:
URL: https://github.com/apache/hive/pull/6263#discussion_r2685071788
##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/test/utils/HiveIcebergTestUtils.java:
##########
@@ -296,7 +298,12 @@ public static void validateFiles(Table table,
Configuration conf, JobID jobId, i
Assert.assertEquals(dataFileNum, dataFiles.size());
Assert.assertFalse(
- new
File(HiveIcebergOutputCommitter.generateJobLocation(table.location(), conf,
jobId)).exists());
+ new File(generateJobLocation(table.location(), conf, jobId)).exists());
+ }
+
+ private static String generateJobLocation(String location, Configuration
conf, JobID jobId) {
Review Comment:
curious as to why are we duplicating the method by removing
@VisibleForTesting in
https://github.com/apache/hive/pull/6263/changes#diff-833afb2122213238e478d859618ecd292511f322545215ccca362afb5e7b23d6L798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
