zabetak commented on code in PR #6202:
URL: https://github.com/apache/hive/pull/6202#discussion_r2689853193
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java:
##########
@@ -1300,9 +1302,10 @@ private static void
runTopNKeyOptimization(OptimizeTezProcContext procCtx)
return;
}
+ String topNKeyRegexPattern = buildTopNKeyRegexPattern(procCtx);
Map<SemanticRule, SemanticNodeProcessor> opRules = new
LinkedHashMap<SemanticRule, SemanticNodeProcessor>();
opRules.put(
- new RuleRegExp("Top n key optimization",
ReduceSinkOperator.getOperatorName() + "%"),
+ new RuleRegExp("Top n key optimization", topNKeyRegexPattern),
Review Comment:
As mentioned in https://github.com/apache/hive/pull/6202/changes#r2675925598
before talking about how to implement a change we need to understand what
change we need to perform and if the change is needed.
The question if we should add or not a TopNKeyOperator below a windowing
(PTF) ReduceSink remains open. Let's finalize the discussion in
https://github.com/apache/hive/pull/6202/changes#r2668127719 and then we can
can come back to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
