deniskuzZ commented on code in PR #6259:
URL: https://github.com/apache/hive/pull/6259#discussion_r2697648460
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -987,6 +987,11 @@ default boolean
isPartitioned(org.apache.hadoop.hive.ql.metadata.Table table) {
return false;
}
+ default boolean isPartitionPresent(org.apache.hadoop.hive.ql.metadata.Table
table,
Review Comment:
> getPartition in iceberg returns dummy partition corresponding to that
partSpec without checking it is already present or not
exactly. i think we need to change that API and also drop the `RewritePolicy
policy` arg (move Context.RewritePolicy.get(conf) inside the StorageHandler).
getPartition() should return dummy partition corresponding to the provided
partSpec only if exists otherwise it confusing.
please check if ATM this method is only used by Iceberg compaction. in that
scenario we could skip the validation (i.e. check for
SessionState.get().isCompaction())
cc @difin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
